Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #386

Merged
merged 17 commits into from
Dec 14, 2023
Merged

Upgrade dependencies #386

merged 17 commits into from
Dec 14, 2023

Conversation

funkyshu
Copy link
Collaborator

@funkyshu funkyshu commented Jul 21, 2023

Updated go.mod/vendor dependencies and set go version to 1.19.
Updated makefile linter image to latest.
Updated github workflows to use latest actions and updated go, dbs, linter test versions.
Fixed linting issues cased by updates/changes in linters.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (31d438d) 96.90% compared to head (730cff9) 96.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files          62       62           
  Lines        3488     3490    +2     
=======================================
+ Hits         3380     3382    +2     
  Misses         92       92           
  Partials       16       16           
Flag Coverage Δ
unittests 96.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database.go 94.06% <ø> (ø)
delete_dataset.go 100.00% <ø> (ø)
exec/query_executor.go 98.48% <ø> (ø)
exec/query_factory.go 100.00% <ø> (ø)
exp/alias.go 86.66% <ø> (ø)
exp/cast.go 100.00% <ø> (ø)
exp/conflict.go 42.10% <ø> (ø)
exp/exp_list.go 85.18% <ø> (ø)
exp/exp_map.go 100.00% <ø> (ø)
exp/ident.go 100.00% <ø> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iredmail
Copy link

iredmail commented Jul 23, 2023

This PR impacts 278 files, which including many other changes besides dependencies.

I suggest rework a new PR and include just dependencies, no more comment lines, linter related changes, etc. Otherwise it's hard for others to review your PR. One change per PR.

@funkyshu funkyshu merged commit 035d999 into master Dec 14, 2023
11 checks passed
@funkyshu funkyshu deleted the upgrade-dependencies branch December 14, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants